Eagerly expand cfg/cfg_attr in pyclasses#6134
Open
mejrs wants to merge 3 commits into
Open
Conversation
Merging this PR will improve performance by 10.74%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_empty_class_init_py |
11.7 µs | 10.6 µs | +10.74% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing mejrs:cfg_eval (03d922d) with main (5c6807d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #5125 (comment)
It's just for enum variants and fields in enums/structs for now. We can expand to impl blocks and functions in the future.
It seems to work reasonably well actually, the main ugly part is handling of pyclass/pyo3 options because we need to parse them to figure out where the pyclass macro is. Thoughts on how to do this better are welcome.
There's also some code dealing with forwarding cfgs that we can remove in the future, in particular the check for empty enums is unreachable now I believe.