deprecate PyRef(Mut) (Part 1)#6120
Open
Icxolu wants to merge 1 commit into
Open
Conversation
Icxolu
commented
Jun 9, 2026
|
|
||
| #[pymethods] | ||
| impl TraverseTriesToTakePyRef { | ||
| #[expect(deprecated)] |
Member
Author
There was a problem hiding this comment.
I just expected these for now. PyClassGuard(Mut) does give the same error, PyClassGuard could be allowed I guess, since it is not mutable and does not give access to a Python token. Not sure if that's worth the effort though
1 task
Icxolu
force-pushed
the
deprecate/pyref
branch
2 times, most recently
from
629eb51 to
a76cce0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of deprecating
PyRefandPyRefMut. This PR deprecates the types itself (targeting 0.30.0 as per #6083 (comment), so leaving as draft for now)We will need a migration guide entry, but I would like to defer that to the second part when I deprecate the
borrowmethods.See also #6083