No std ThreadId#6056
Conversation
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, one comment on the FFI definition (see below).
Do you expect that the test suite (which does a lot of thread spawning) will need to change?
I don't think it will need to change, but it might be worth enabling it for wasm build and pulling in one of the wasm threading crates as a dev dependency. |
22f6ce6 to
2f2eb80
Compare
2f2eb80 to
513cc78
Compare
Merging this PR will improve performance by 12.96%
Performance Changes
Tip Curious why this is faster? Comment Comparing |
|
@codspeedbot explain why this is faster |
|
Should we exclude PyPy from |
Re-implement
ThreadIdusingPyThread_get_thread_ident. This makes is usable inno_stdcontext.