Introduce the concept of grab signal override from extensions #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR patch a problem with the fact that the output of the DataMixer can be added to the Dashboard to be used by other extensions such as the DAQ_Scan.
But, let's say I want to use the Mixer to plot some interesting live data out of a detector call mydet. I'll have in the Dahsbord a real detector: mydet and a "fake" one: mymixeddata. If I do a scan of mymixeddata as a function of one or more parameters, the grab signal of mydet will be fired once byt the datamixer. All is fine. BUT If I do a scan of mymixeddata and of mydet (to store the raw data) as a function of one or more parameters, the grab signal of mydet will be fired twice for each param. Once by the direct call of the daq_scan to mydet and once by the datamixer. This is bad.
In pymodaq PR PyMoDAQ/PyMoDAQ#588 introduces ways to handle this tohether with the commits in here