Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions isort/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,8 @@ def sort_stream(
if not output_stream.readable():
_internal_output = StringIO()

if config.sort_reexports and not _internal_output.seekable():
_internal_output = StringIO()
try:
changed = core.process(
input_stream,
Expand Down
24 changes: 24 additions & 0 deletions tests/unit/test_regressions.py
Original file line number Diff line number Diff line change
Expand Up @@ -1985,3 +1985,27 @@ def test_comment_on_opening_line_of_aliased_import_does_not_move():
isort.code(short_line, profile="black")
== "from mod import attr as alias # type: ignore[attr-defined] # My comment\n"
)

def test_sort_reexports_with_non_seekable_stream_issue_2393():
"""Ensure --sort-reexports does not crash when output stream is non-seekable (e.g. stdin).
See: https://github.com/PyCQA/isort/issues/2393
"""
import sys
from io import StringIO

code = "from test import B, A\n__all__ = ['B', 'A']\n"
input_stream = StringIO(code)
isort.api.sort_stream(
input_stream=input_stream,
output_stream=sys.stdout,
sort_reexports=True,
)
input_stream = StringIO(code)
output_stream = StringIO()
isort.api.sort_stream(
input_stream=input_stream,
output_stream=output_stream,
sort_reexports=True,
)
output_stream.seek(0)
assert "import A, B" in output_stream.read()