Conversation
simonmicro
added
documentation
There was a problem hiding this comment.
Pull request overview
This PR implements semantic versioning for the py-kms project by refactoring version tracking from branch-based to reference-based (supporting tags). The changes prepare the project for a v1.0.0 release with proper Git-based tagging.
Key Changes:
- Renamed all
branch/BUILD_BRANCHreferences toreference/BUILD_REFERENCEthroughout the codebase - Updated GitHub Actions workflows to support version tag-based builds and modernized action versions
- Reorganized README.md with cleaner structure and added semantic versioning documentation
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| py-kms/templates/base.html | Updated UI text from "branch" to "reference" for version display |
| py-kms/pykms_WebUI.py | Changed dictionary key from 'branch' to 'reference' in version info |
| docs/Contributing.md | Updated contribution guidelines to reference the next branch |
| docker/docker-py3-kms/Dockerfile | Renamed build argument from BUILD_BRANCH to BUILD_REFERENCE |
| README.md | Restructured README with semantic versioning info and cleaner formatting |
| CHANGELOG.md | Added deprecation notice indicating migration to Git-based releases |
| .github/workflows/bake_to_version.yml | New workflow for building version-tagged Docker images |
| .github/workflows/bake_to_test.yml | Updated to use BUILD_REFERENCE and upgraded checkout action |
| .github/workflows/bake_to_next.yml | Updated naming, Docker tags structure, and action versions |
| .github/workflows/bake_to_latest.yml | Changed trigger from branch push to tag push and updated references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
simonmicro
force-pushed
the
feature/semantic_version
branch
from
b38260b to
1621f9a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: simonmicro <simon@simonmicro.de>
Author
|
Merged regardless, due to no reaction of requested reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #116
...the reset of this we have to do at the next release:
mainv1.0.0and create a GitHub release from it (this will then auto-trigger a workflow for a tagged Docker image being built)