perf: cache loaded templates in memory#129
Open
Darkroom4364 wants to merge 1 commit intoPwnKit-Labs:mainfrom
Open
perf: cache loaded templates in memory#129Darkroom4364 wants to merge 1 commit intoPwnKit-Labs:mainfrom
Darkroom4364 wants to merge 1 commit intoPwnKit-Labs:mainfrom
Conversation
Contributor
Darkroom4364
commented
Apr 12, 2026
- Module-level cache avoids re-reading YAML on every call
- clearTemplateCache() export for tests
Darkroom4364
commented
Apr 12, 2026
Contributor
Author
Darkroom4364
left a comment
There was a problem hiding this comment.
Scope: Only loader.ts + index.ts touched — confirmed, clean.
Cache logic: Correct. The cache stores the full unfiltered list; depth filtering is applied on read via .filter(), so a depth=passive call doesn't poison the cache for later depth=active calls. loadTemplateById benefits automatically since it calls loadTemplates().
One nit: loadTemplates returns _cache directly (not a copy). Any caller mutating the returned array (push/splice) would corrupt the cache. Returning [..._cache] (shallow copy) would be safer, but fine to skip if callers are read-only today.
clearTemplateCache is exported from both loader.ts and index.ts. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.