Add CustomFormatter support#4
Draft
okms wants to merge 1 commit into
Draft
Conversation
Contributor
|
Denied! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for custom view formatting in list and document views, ensuring that custom formatter objects are properly handled and serialized. The main changes include schema updates, code modifications to normalize custom formatter settings, and integration of these improvements in handlers for lists and files.
Schema enhancements:
CustomFormatterproperty to theAdditionalSettingssection of theIListViewinterface and updatedschema.jsonto accept both string and object types forCustomFormatter. [1] [2]View configuration improvements:
all-simple.tsto include aViewsarray with a sample custom formatter configuration for the "All Documents" view.Normalization utility:
normalizeViewAdditionalSettingsfunction insrc/util/index.tsto serializeCustomFormatterobjects into strings, ensuring compatibility with SharePoint APIs.Handler integration:
ListsandFileshandlers to usenormalizeViewAdditionalSettingswhen updating or adding views, so that custom formatter objects are always serialized before being sent to SharePoint. [1] [2] [3] [4] [5]