Skip to content

Fix transport type issue and Purity version mismatch issues #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdodsley merged 4 commits into from
Jan 23, 2026
Merged

Fix transport type issue and Purity version mismatch issues #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c286d0
Fix transport type issue and mismatched versions failures
sdodsley Jan 14, 2026
b6cd6ae
Merge branch 'master' into connect_fix
sdodsley Jan 19, 2026
c777a12
Merge branch 'master' into connect_fix
sdodsley Jan 19, 2026
8de5564
Merge branch 'master' into connect_fix
sdodsley Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/890_transport_fix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- purefa_connect - Fixed issue where incorrect transport type was passed.
52 changes: 33 additions & 19 deletions plugins/modules/purefa_connect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,11 @@

HAS_PYPURECLIENT = True
try:
from pypureclient import flasharray
from pypureclient.flasharray import (
ArrayConnectionPost,
ArrayConnectionPatch,
Client,
)
except ImportError:
HAS_PYPURECLIENT = False

Expand Down Expand Up @@ -232,14 +236,14 @@ def update_connection(module, array, target_array):
res = array.patch_array_connections(
names=[target_array.name],
renew_encryption_key=True,
array_connection=flasharray.ArrayConnectionPatch(),
array_connection=ArrayConnectionPatch(),
context_names=[module.params["context"]],
)
else:
res = array.patch_array_connections(
names=[target_array.name],
renew_encryption_key=True,
array_connection=flasharray.ArrayConnectionPatch(),
array_connection=ArrayConnectionPatch(),
)
if res.status_code != 200:
module.fail_json(
Expand All @@ -256,14 +260,14 @@ def update_connection(module, array, target_array):
res = array.patch_array_connections(
names=[target_array.name],
refresh=True,
array_connection=flasharray.ArrayConnectionPatch(),
array_connection=ArrayConnectionPatch(),
context_names=[module.params["context"]],
)
else:
res = array.patch_array_connections(
names=[target_array.name],
refresh=True,
array_connection=flasharray.ArrayConnectionPatch(),
array_connection=ArrayConnectionPatch(),
)
if res.status_code != 200:
module.fail_json(
Expand All @@ -282,7 +286,7 @@ def update_connection(module, array, target_array):
encrypted = "unencrypted"
if target_array.encryption != encrypted:
# Changing the encryption type requires the connection key
remote_system = flasharray.Client(
remote_system = Client(
target=module.params["target_url"],
api_token=module.params["target_api"],
user_agent=user_agent,
Expand All @@ -297,15 +301,15 @@ def update_connection(module, array, target_array):
if LooseVersion(CONTEXT_VERSION) <= LooseVersion(api_version):
res = array.patch_array_connections(
names=[target_array.name],
array_connection=flasharray.ArrayConnectionPatch(
array_connection=ArrayConnectionPatch(
encryption=encrypted, connection_key=connection_key
),
context_names=[module.params["context"]],
)
else:
res = array.patch_array_connections(
names=[target_array.name],
array_connection=flasharray.ArrayConnectionPatch(
array_connection=ArrayConnectionPatch(
encryption=encrypted, connection_key=connection_key
),
)
Expand All @@ -321,15 +325,15 @@ def update_connection(module, array, target_array):
if LooseVersion(CONTEXT_VERSION) <= LooseVersion(api_version):
res = array.patch_array_connections(
names=[target_array.name],
array_connection=flasharray.ArrayConnectionPatch(
array_connection=ArrayConnectionPatch(
type=module.params["connection"]
),
context_names=[module.params["context"]],
)
else:
res = array.patch_array_connections(
names=[target_array.name],
array_connection=flasharray.ArrayConnectionPatch(
array_connection=ArrayConnectionPatch(
type=module.params["connection"]
),
)
Expand Down Expand Up @@ -360,33 +364,43 @@ def create_connection(module, array):
"version": 1.5,
"platform": platform.platform(),
}
remote_system = flasharray.Client(
remote_system = Client(
target=module.params["target_url"],
api_token=module.params["target_api"],
user_agent=user_agent,
)
connection_key = list(
remote_system.get_array_connections_connection_key(
try:
connections = remote_system.get_array_connections_connection_key(
encrypted=module.params["encrypted"]
).items
)[0].connection_key
)
except TypeError as exc:
if module.params["encrypted"] == "encrypted":
module.warning(
msg=(
"Remote array version of Purity//FA does not support "
"encryption. Continuing without encryption"
),
)
connections = remote_system.get_array_connections_connection_key()

connection_key = list(connections.items)[0].connection_key
if LooseVersion(ENCRYPT_VERSION) >= LooseVersion(api_version):
if module.params["encrypted"]:
encrypted = "encrypted"
else:
encrypted = "unencrypted"
array_connection = flasharray.ArrayConnectionPost(
array_connection = ArrayConnectionPost(
type=module.params["connection"].lower(),
management_address=module.params["target_url"].strip("[]"),
replication_transport=module.params["connection"],
replication_transport=module.params["transport"],
connection_key=connection_key,
encryption=encrypted,
)
else:
array_connection = flasharray.ArrayConnectionPost(
array_connection = ArrayConnectionPost(
type=module.params["connection"].lower(),
management_address=module.params["target_url"].strip("[]"),
replication_transport=module.params["connection"],
replication_transport=module.params["transport"],
connection_key=connection_key,
)
if not module.check_mode:
Expand Down