Fix mb_strlen UTF-8 character counting (closes #158)#391
Merged
Conversation
Use host mb_strlen when available, VmString::utf8CharLength fallback, and __compiler_utf8_strlen for JIT/AOT. Add compliance PHPT for é and hello. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mb_strlen()now returns UTF-8 codepoint counts (not byte length) for default/UTF-8encoding in VM and JITmb_strlen()when mbstring is available, withVmString::utf8CharLength()fallback__compiler_utf8_strlenruntime helper; compile-time string literals fold at build timeéandhelloTest plan
vendor/bin/phpunit --filter mb_strlen test/inphp-compiler:22.04-dev(2 tests OK)Closes #158
Made with Cursor