AOT: fix hashtable string index reads and add array_fill PHPT#388
Merged
Conversation
…PHPT. Packed-list elements stored as strings were fetched via readLongAt, so echo printed zeros. Read the slot type and box the value for mixed-type index access. Co-authored-by: Cursor <cursoragent@cursor.com>
Regenerate bootstrap-inventory.md after merge. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/fixtures/aot/cases/array_fill.phpt— end-to-end AOT compile/link/run forarray_fill()with string values and integer keys.array_fill(0, 3, 'x')) were always loaded via__hashtable__readLongAt, soecho $a[0]printed0instead of the string.HashTableHelper::readIndexedToValueBox()andJitValueBox::copyFromPointer()so mixed-type hashtable slots are read by runtime type tag and assigned into boxed__value__destinations.Root cause
Variable::dimFetch()onTYPE_HASHTABLEusedreadLongAtwhen no static string type was expected. String slots written byarray_fillstill holdTYPE_STRINGin the__value__union.Test output (Docker
php-compiler:22.04-dev)Manual spot-check:
Test plan
./script/docker-ci-local.shinphp-compiler:22.04-devvendor/bin/phpunit --group aot— 91 tests, 225 assertionsMade with Cursor