Language: double-quoted string interpolation (VM) — closes #261#383
Merged
Conversation
…261). ConcatList lowering was already present; close gaps for null/undefined toString, class property defaults in encapsed braces, and PHPT coverage for VM and JIT. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConcatListlowering for encapsed strings was already inlib/Compiler.php; this PR closes VM/runtime gaps for interpolation.Variable::toString()now handlesnull, undefined, arrays, and objects forTYPE_CONCAT/ echo paths.TYPE_DECLARE_PROPERTYso{$obj->prop}works.test/compliance/cases/language/.Closes #261
Test plan
vendor/bin/phpunit test/compliance/VMTest.php— 200/200 compliance OK (Dockerphp-compiler:22.04-dev)./script/docker-ci-local.sh— VM + serve phases OK (395 tests)encapsed_string_jit.phpt) — harnessbin/jit.phpsegfaults on MCJIT probe (pre-existing); AOT phase has 3 unrelatedgetenv/putenvfailures on this hostMade with Cursor