Stdlib: getallheaders() JIT/AOT from sg_SERVER#378
Merged
Conversation
Emit LLVM that copies HTTP_* and CONTENT_* entries from the baked sg_SERVER hashtable at compile time, with VM parity unchanged and compliance PHPT coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve bootstrap-inventory.md conflict; keep getallheaders JIT/AOT work. Co-authored-by: Cursor <cursoragent@cursor.com>
Keeps ci-local.sh --check green on the getallheaders JIT/AOT branch. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getallheaders()for JIT/AOT by emitting LLVM that copiesHTTP_*/CONTENT_*keys from the bakedsg_SERVERhashtable (same header-name mapping as VM viaSuperglobals::serverKeyToHeaderName()).JitGetallheadershelper and wiregetallheaders_::call(); extendJIT::assignOperand()to box hashtable returns into__value__.JIT/AOTyes).Closes #307
Test plan
php bin/vm.phpwithHTTP_X_TEST/HTTP_HOSTenv →yes/example.testphp script/capability-matrix.php --checkvendor/bin/phpunit test/unit/Web/SuperglobalsHttpHeadersTest.phpvendor/bin/phpunit test/compliance/JITTest.php(requires LLVM 9 +source script/php-env.shinphp-compiler:22.04-dev)./script/docker-ci-local.shfull suite (VM phase; harness may skip unrelated language PHPT failures)Made with Cursor