Web: CONTENT_LENGTH for incoming POST (fixes #314)#319
Merged
Conversation
Sync CGI CONTENT_LENGTH from the bytes read when the client sends Content-Length; add unit, PHPT, and serve integration coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$_SERVER['CONTENT_LENGTH']and CGI env from the HTTPContent-Lengthheader using the number of body bytes actually read (not chunked requests without that header; see Web: DevServer POST bodies without Content-Length (chunked transfer-encoding) #287).Content-LengthinDevServer::respond(); this PR focuses on the incoming CGI path for VM serve and AOTserve-aot.ServeTest/ServeAotTestPOST integration tests.Test plan
vendor/bin/phpunit --exclude-group serve,llvm --filter ContentLength(unit + header mapping)./script/docker-ci-local.sh --filter ContentLength(unit slice; serve group needs loopback)./script/docker-ci-local.shon a host with working serve integrationCloses #314
Made with Cursor