Web: $_SERVER['DOCUMENT_ROOT'] for docroot-relative paths (#296)#305
Merged
Conversation
Expose the serve docroot in VM and AOT superglobals so scripts can build docroot-relative paths. DevServer sets DOCUMENT_ROOT per request; AOT refresh copies it from the environment. Includes VM/AOT/serve regression tests and fixes ServeAotTest compile env PATH merging. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$_SERVER['DOCUMENT_ROOT']from theDOCUMENT_ROOTCGI environment variable in VM superglobals and AOT__superglobals__refresh.bin/serve.php/serve-aot) setsDOCUMENT_ROOTto the resolved docroot on every request.ServeTest,ServeAotTest, andRuntimeSuperglobalRefreshTest.ServeAotTest::compileExampleto merge LLVM env intobaseEnv()soproc_openretains a usablePATHforphp/env.Closes #296.
Test plan
docker run … php vendor/bin/phpunit --filter DocumentRoot(unit, serve, AOT refresh)bash script/ci-local.sh --filter DocumentRootinphp-compiler:22.04-dev(VM + serve + AOT refresh)script/ci-local.shon a host with loopback + LLVM (recommended before release)Made with Cursor