test: PhpcCliTest regression for phpc run -q/-p (closes #294)#301
Merged
Conversation
Extend PhpcCliTest with POST body (-p), missing-script exit code, and a shared runPhpc helper. Use $_REQUEST in 001-SimpleWeb so POST matches the documented GET-or-POST behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PhpcCliTestwithphpc run -pPOST body coverage, missing-script non-zero exit, and a sharedrunPhpchelper.examples/001-SimpleWeb/example.phpto read$_REQUEST['name']so POST via-pmatches the file’s documented GET-or-POST behavior.Test plan
docker run … script/ci-local.sh --filter PhpcCliTest(via./script/docker-ci-local.sh)PhpcCliTest+ExamplesCompileTestgreen inphp-compiler:22.04-devCloses #294
Made with Cursor