test(aot): add array_shift LLVM compile-and-run PHPT#283
Merged
Conversation
Cover array_shift() on packed list arrays via bin/compile.php, matching the existing array_pop AOT fixture pattern. Update capabilities.md. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/fixtures/aot/cases/array_shift.phptexercised byAotTestviabin/compile.php(LLVM 9 inphp-compiler:22.04-dev).array_shiftas AOT PHPT indocs/capabilities.md(already had JIT PHPT).Test output (Docker, tar pipe — bind-mount empty on harness)
Image:
php-compiler:22.04-dev,PHP_COMPILER_LLVM_PATH=/opt/llvm9,script/apply-patches.shapplied.Notes
array_shift($a) === nullon an empty array: that path segfaults in the AOT binary today (empty shift without comparing to null is fine). Full JIT compliance case still covers null via VM/JIT.script/docker-ci-local.sh(tar fallback) for fullci-local.sh.Test plan
AotTestPHPT fixtures (40/40)ExampleWebAotTestweb examples AOTscript/ci-local.shin Docker (recommended before merge on hosts with working bind-mount)Made with Cursor