Lint: Register Phase-2 blockers in UnsupportedRegistry (#258)#267
Merged
Conversation
Register ternary, compound assign, break/continue, and match CFG kinds with correct GitHub issues; fix yield (#167) and closure/arrow mappings. Add unit and lint integration tests; refresh bootstrap inventory. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
issue-258-unsupported-registry
branch
from
bbead68 to
dc3dac2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnsupportedRegistry::KIND_TO_ISSUEfor ternary (Language: Ternary operator (?:) in compiler pipeline #114), compound assign (Language: Compound assignment operators (.=, +=, -=, *=, etc.) #136), break/continue (Language: break and continue for loops and switch #115), and match (Language: match expression (PHP 8) #143).Expr_Yield/Expr_YieldFrom→ Language: Generators (yield and yield from) #167;Expr_Closure→ Language: Closures and anonymous functions #72;Expr_ArrowFunction→ Language: Arrow functions (fn() => expr) #142.UnsupportedRegistryTestand lint integration tests for shift-assign and yield.docs/unsupported-syntax.mdand regeneratedocs/bootstrap-inventory.md.Test plan
vendor/bin/phpunit --filter UnsupportedRegistryTestvendor/bin/phpunit --filter LintTestphp script/bootstrap-inventory.php --checkscript/docker-ci-local.sh --filter UnsupportedRegistryTest(via tar pipe on harness)Closes #258
Made with Cursor