AOT: fix JUMPIF codegen, add web POST PHPT#256
Merged
Conversation
Emit conditional branches on the predecessor block before compiling if/else targets so LLVM modules verify. Map REQUEST_BODY to compile -p in AotTest, add web_post.phpt, and fix boxed === null strcmp typing. Co-authored-by: Cursor <cursoragent@cursor.com>
26c3e56 to
12fea86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
branchIfthere after compiling targets (fixes missing terminators that broke AOT tests using ternaries/boolval/etc.).test/fixtures/aot/cases/web_post.phptand mapREQUEST_BODY→bin/compile.php -pinAotTest(LLVM binary reads$_POSTbaked at compile time).JitValueCompare:=== nullagainst boxed values; cast__string__*tochar*forstrcmp.array_pop.phptto the stable pop/count assertions (full=== nullafter double-pop still needs a separate fix).Test plan (Docker,
php-compiler:22.04-dev)Results
Harness note: bind-mount may be empty; use
script/docker-ci-local.sh(tar pipe).Made with Cursor