Stdlib: str_replace() JIT/AOT lowering (#82)#240
Merged
Conversation
Add JitStrReplace using strstr, jitCopySlice, and JitStringConcat so str_replace compiles on the static/AOT path used by bin/compile.php. Includes JIT and AOT PHPT coverage and updates the capability matrix. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
str_replace()via newJitStrReplacehelper (strstr loop + slice + concat), matching the VM byte-safe algorithm inVmString::strReplace.ext/standard/str_replace.phpcall()for JIT/AOT;bin/compile.phpalready loads the standard module.str_replace_jit.phptcompliance coverage andtest/fixtures/aot/cases/str_replace.phptAOT fixture; updatesdocs/capabilities.md.Closes the
str_replaceportion of #82 (implode/explodewere already JIT/AOT-capable).Test plan
php bin/vm.php/php bin/jit.phponstr_replace('o','0','foo')→f00php bin/compile.php -o /tmp/out+ run binary (LLVM + libjansson in dev image)php script/capability-matrix.php --checktar … | docker run … ./script/ci-local.sh(withlibjansson4for AOT link)Made with Cursor