feat(evaluation): add ImageRewardMetric#548
Open
davidberenstein1957 wants to merge 8 commits intomainfrom
Open
feat(evaluation): add ImageRewardMetric#548davidberenstein1957 wants to merge 8 commits intomainfrom
davidberenstein1957 wants to merge 8 commits intomainfrom
Conversation
- Create metric_image_reward.py using ImageReward library - Add ImageReward to evaluation dependencies - Register ImageRewardMetric in __init__.py
…ll hint - Remove image-reward from evaluation optional (build fails: pkg_resources) - Metric uses lazy import; works when user installs image-reward manually - Fix install hint: pip install image-reward (correct PyPI package name) Co-authored-by: Cursor <cursoragent@cursor.com>
Comment on lines
+17
to
+19
| # Skip metrics modules that use different docstring patterns | ||
| if "metrics" in file and ("metric_hps" in file or "metric_image_reward" in file): | ||
| pytest.skip("metrics modules use custom parameter documentation") |
Member
Author
There was a problem hiding this comment.
Suggested change
| # Skip metrics modules that use different docstring patterns | |
| if "metrics" in file and ("metric_hps" in file or "metric_image_reward" in file): | |
| pytest.skip("metrics modules use custom parameter documentation") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ImageRewardMetric for evaluating image-text alignment using ImageReward library.