Draft
Conversation
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
niklaslong
reviewed
Dec 3, 2025
| ErasedJson::pretty(record_counts) | ||
| } | ||
|
|
||
| /// GET /{network}/{block}/record_count |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// GET /{network}/{block}/record_count | |
| /// GET /{network}/block/{block}/record_count |
raychu86
reviewed
Dec 4, 2025
| } | ||
|
|
||
| /// GET /{network}/record_count | ||
| pub(crate) async fn get_number_of_records(State(rest): State<Self>) -> ErasedJson { |
Collaborator
There was a problem hiding this comment.
This endpoint will be quite expensive, can we put it behind auth to prevent DoSing nodes? - ProvableHQ/snarkVM#3047 (comment)
Collaborator
Author
There was a problem hiding this comment.
as mentioned in the linked thread, this operation is in general less expensive than just obtaining a block; what should the criteria for auth-gating be? some fixed amount of time on reference hardware, or just algorithmic complexity (even if it's unlikely to be a concern until very large numbers are reached)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snarkOS counterpart to ProvableHQ/snarkVM#3047.
Filing as a draft due to the corresponding snarkVM branch not having been merged yet.