Skip to content

Enhance WebView debugging with exception handling and logging #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cameronaaron wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enhance WebView debugging with exception handling and logging #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/java/me/proton/android/lumo/webview/JsInjector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,7 +1069,8 @@ fun injectAndroidInterfacePolyfill(webView: WebView) {
console.log('✅ Android.showPayment is immediately available');
} else {
console.log('⚠️ Android.showPayment not yet available - retry logic will be used');
window.AndroidInterface.debugStatus();
// Note: debugStatus method not implemented - using console logging instead
console.log('AndroidInterface status: methods available =', Object.keys(window.Android || {}));
}
})();
""".trimIndent()
Expand Down
16 changes: 12 additions & 4 deletions app/src/main/java/me/proton/android/lumo/webview/WebViewScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,11 +187,19 @@ fun WebViewScreen(
if (BuildConfig.ENABLE_WEBVIEW_DEBUG) {
// Only include the debugging method call in standard variants
if (BuildConfig.DEBUG) {
WebView.setWebContentsDebuggingEnabled(true)
Log.d(TAG, "WebView debugging enabled (debug + standard variant)")
try {
WebView.setWebContentsDebuggingEnabled(true)
Log.d(TAG, "WebView debugging enabled (debug + standard variant)")
} catch (e: Exception) {
Log.w(TAG, "Failed to enable WebView debugging it may not be supported on this system", e)
}
} else {
WebView.setWebContentsDebuggingEnabled(false)
Log.d(TAG, "WebView debugging disabled (release build)")
try {
WebView.setWebContentsDebuggingEnabled(false)
Log.d(TAG, "WebView debugging disabled (release build)")
} catch (e: Exception) {
Log.w(TAG, "Failed to disable WebView debugging - may not be supported on this system", e)
}
}
} else {
// For noWebViewDebug variant, completely omit the method call
Expand Down