Remove check for the executable to be in /Applications#2
Open
delafthi wants to merge 1 commit intoProtonDriveApps:mainfrom
Open
Remove check for the executable to be in /Applications#2delafthi wants to merge 1 commit intoProtonDriveApps:mainfrom
delafthi wants to merge 1 commit intoProtonDriveApps:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sry, for doing it this way but I'm not sure how to get in touch with you.
I'm packaging Proton Drive for nixpkgs (NixOS/nixpkgs#493395). However, the production build has a hardcoded restriction that only allows executable paths starting with
/Applications, which breaks Proton Drive when installed via Nix.Nix installs applications to the immutable
/nix/storedirectory and then creates symlinks to:/Users/<user>/Applications/Home Manager Apps/(when using home-manager)/Applications/Nix Apps/(when using nix directly)Since these symlink locations don't always match the
/Applicationsrequirement, Proton Drive fails to launch.Questions
/Applicationspath check?