Unfreeze density or density_thermal as needed#292
Open
Conversation
- Sets `density` or `density_thermal` as appropriate - Errors if ion density is negative
Contributor
for any shot
|
Member
Author
|
@nanshi1177 Give that a try |
Use `=` instead of `.=` to assign density_fast = 0, so that setproperty! is called and IMAS actually stores the value. The previous `.=` operated on a temporary returned by getproperty and was silently discarded, leaving density_fast unstored and causing a circular expression loop between density_fast and density_thermal. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
I think this is ready to merge. |
Member
Author
|
Does it fix the problem in ProjectTorreyPines/FUSE.jl#1057 as well, or is that a separate issue? |
Contributor
I believe the QN issue has been solved. I have test several shots in reconstruction mode and it works well. However,PR#1057 isn't ready to merge yet. There is an additional fix in flux_matcher_actro.jl that I am concerned might cause issues in predictive mode. I am currently looking into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enforce_quasi_neutrality!to setdensityordensity_thermalas appropriate depending on whetherdensity_fastis present, instead of blanket-unfreezing alldensityfields upfrontunfreeze!calls infast_particles_profiles!,bundle_DT!,new_impurity_fraction!, andscale_ion_densities_to_target_zeff!so thatdensityexpressions remain correct afterdensity_thermalmodificationsTest plan
enforce_quasi_neutrality!correctly updatesdensityvsdensity_thermalbased on presence ofdensity_fast🤖 Generated with Claude Code