Fix incorrect ion mass in total source and total flux#284
Merged
Conversation
Also "retrhow" typo
jmcclena
approved these changes
Nov 13, 2025
Contributor
jmcclena
left a comment
jmcclena
left a comment
There was a problem hiding this comment.
Looks like a bug to me.
Contributor
|
Auch. Definitely a bug, but I suspect we mostly (always?) take the ions information from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have no idea what physical effect this has but it seems bad. I'll run the run FUSE regresssions.
Companion to ProjectTorreyPines/GACODE.jl#5
Also fixes "retrhow" typo