use api4 rather than api3 in filterDeletedContacts#535
Open
ufundo wants to merge 1 commit into
Open
Conversation
ufundo
force-pushed
the
fix-filter-deleted
branch
from
ffd5caf to
16b3188
Compare
ufundo
changed the title
jensschuppe
added
enhancement
status:needs work
Collaborator
|
APIv4++ 👍 @ufundo can you try making PHPStan and PHP_CodeSniffer happy so we can merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~~If you pass a large number of contacts to
filterDeletedContacts, you hit implicit limit in api3, which then means you lose some contacts that you shouldn't.Switching to api4 fixes this.~~
Oh sorry looks like this is already fixed on master by #496
Converting to api4 still probably good in the long run...