PHP8 compatibility #500
Merged
PHP8 compatibility #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjendres
added
the
incompatibility
dontub
requested changes
Dec 12, 2025
Collaborator
dontub
left a comment
dontub
left a comment
There was a problem hiding this comment.
Can you also have a look at the phpcs and phpstan issues? I think most issues found by phpcs should be fixable with phpcbf.
| 'total' => $stmt->total, | ||
| 'currency' => $stmt->currency, | ||
| 'date' => strtotime($stmt->starting_date), | ||
| 'date' => strtotime($stmt->starting_date ?? '2000-01-01 00:00:00'), |
Collaborator
There was a problem hiding this comment.
What's the reason for the chosen fallback? Could it also be 0000-00-00 or 01-01-1970?
Member
Author
There was a problem hiding this comment.
I picked this default because it's more compatible, e.g. in the "seconds since 1970 notation.
| } | ||
| #btx-details .btxheader { | ||
| background: url("{$base_url}/sites/all/modules/civicrm/i/TreePlus.gif") 4px 4px no-repeat; | ||
| /*background: url("{$base_url}/sites/all/modules/civicrm/i/TreePlus.gif") 4px 4px no-repeat;*/ |
Collaborator
There was a problem hiding this comment.
If this isn't needed I think it should be removed.
Member
Author
There was a problem hiding this comment.
It used to work, but the TreePlus.gif isn't part of CiviCRM any more.
bjendres
force-pushed
the
php83_compatibiliy
branch
from
f24116d to
e384027
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of naughty and hard to track down errors during CiviBankings' analysis phase.