Skip to content

Fix BotBindingModal to follow event_source_modal #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alanpoon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix BotBindingModal to follow event_source_modal #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,9 @@ script_mod! {
}
bot_binding_modal := Modal {
content +: {
height: Fill,
width: Fill,
align: Align{x: 0.5, y: 0.5},
bot_binding_modal_inner := BotBindingModal {}
}
}
Expand Down
12 changes: 9 additions & 3 deletions src/home/bot_binding_modal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,17 @@ script_mod! {
}

mod.widgets.BotBindingModal = #(BotBindingModal::register_widget(vm)) {
width: Fit
height: Fit
width: Fill { max: 1000 }
// TODO: i'd like for this height to be Fit with a max of Rel { base: Full, factor: 0.90 },
// but Makepad doesn't allow Fit views with a max to be scrolled.
height: Fill // { max: 1400 }
margin: 40,
align: Align{x: 0.5, y: 0}
flow: Down
padding: Inset{top: 20, right: 25, bottom: 20, left: 25}

RoundedView {
width: 448
width: Fill
height: Fit
align: Align{x: 0.5}
flow: Down
Expand Down
Loading