Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐳What's new?
When assembling zoomed spectrograms on APLOSE, there was some error in the joint between adjacent zooms because of the padding that is made at the beginning/end of the audio (in this new OSEkit, each zoomed part is a distinct spectrogram, so the padding occurs at both end of the joint).
This PR addresses that issue.
🐳How does it work?
It seems a bit hacky, but here's how I do:
This way, it more or less does as if I padded the sliding windows with the actual audio data that comes outside the SpectroData boundaries.
Not sure if this is 100% valid in signal processing theory, but that seems to do the job on the output spectrograms:
I've put the two split part spectrograms just next to each other so that the cut remains visible: By switching from the old duplicated zero-padding to the one from this PR, we can see that the joint is much clother to what happens in the
originalspectrogram (which is a single spectrogram plotted over the non-splitted data).