Skip to content

Conversation

@mathieudpnt
Copy link
Contributor

The current job class does not handle boolean flag for pbs files, i.e. if one parse a boolean argument to a job instance, the value is treated as a string

script_arg = {arg_bool: False}

will write

--arg_bool False

However to parse booleans argument, one must respct the following convention:

--arg_bool

if set to True, else:

--no-arg_bool

I have added a private Job method to build the string representation of listed arguments that handles boolean values: _build_arg_string

@mathieudpnt mathieudpnt self-assigned this Nov 20, 2025
@mathieudpnt mathieudpnt added the data format Work related to spectrogram/audio format and how to process it label Nov 20, 2025
@Gautzilla
Copy link
Contributor

I like that, thanks!

I might tweak some lines in the osekit.public_api.dataset module to take this into account before merging but LGTM otherwise

@mathieudpnt
Copy link
Contributor Author

mathieudpnt commented Dec 10, 2025

{81ED15C6-2667-4F81-8528-4104A98BF91D}

quinquin-carpentier

Copy link
Contributor

@Gautzilla Gautzilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QuinquinCarpentierGIF

@mathieudpnt mathieudpnt merged commit 5d9e57b into Project-OSmOSE:main Dec 10, 2025
2 checks passed
@mathieudpnt mathieudpnt deleted the feature/job_boolean_flag branch December 10, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data format Work related to spectrogram/audio format and how to process it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants