Conversation
1ec5
commented
Apr 2, 2019
1ec5
force-pushed
the
1ec5-pt-2019-04-02
branch
from
241fffb to
8122ea4
Compare
6 tasks
1ec5
commented
Dec 4, 2019
| "short": "Você chegou", | ||
| "short-upcoming": "Você vai chegar", | ||
| "named": "Você chegou a (ao) {waypoint_name}, logo em frente" | ||
| "named": "Você chegou a {waypoint_name}, logo em frente" |
Member
Author
Member
Author
|
This PR is ready for a final review, now that the grammatical question has been split off as #294. |
danpaz
reviewed
Dec 4, 2019
danpaz
approved these changes
Dec 4, 2019
Contributor
danpaz
left a comment
danpaz
left a comment
There was a problem hiding this comment.
I assume you skipped translating the junction_name strings in portugese intentionally right? Otherwise LGTM.
Contributor
|
Ah and reminder to update the changelog 📝 |
1ec5
force-pushed
the
1ec5-pt-2019-04-02
branch
from
5971e65 to
b641a6b
Compare
Member
Author
|
Whoops, forgot to interactively commit those changes. I’ve limited the changes to just the changes in Transifex. I added a blurb to the changelog since the affected strings are fairly prominent. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronized the Portuguese localizations with Transifex. Thanks to @xendez and @jppcel for the updates.
/cc @danpaz