Add RegExp 'global' option to Russian grammar rules#228
Open
yuryleb wants to merge 2 commits intoProject-OSRM:masterfrom
Open
Add RegExp 'global' option to Russian grammar rules#228yuryleb wants to merge 2 commits intoProject-OSRM:masterfrom
yuryleb wants to merge 2 commits intoProject-OSRM:masterfrom
Conversation
Contributor
Author
|
osrm-frontend (with formatToken() fix) also works. |
yuryleb
force-pushed
the
ru-grammar-flags
branch
from
d005948 to
65a0afc
Compare
yuryleb
force-pushed
the
ru-grammar-flags
branch
3 times, most recently
from
ea4efcb to
c739a1e
Compare
yuryleb
force-pushed
the
ru-grammar-flags
branch
from
7fe8924 to
0b3f41d
Compare
yuryleb
force-pushed
the
ru-grammar-flags
branch
from
84138f2 to
7832e4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Some non-JS string replace with regular expression implementations, such as Swift, always use global search option.
This PR adds this
goption explicitly to Russian grammar meta block and updates tests to requiregmeta flags for all existing and future grammars.Tasklist
goption to grammar and tests/cc @1ec5