Skip to content

Fix inconsistent cell count in cucumber guidance tables#7407

Draft
Claude wants to merge 5 commits intomasterfrom
claude/add-locations-to-guidance-tests
Draft

Fix inconsistent cell count in cucumber guidance tables#7407
Claude wants to merge 5 commits intomasterfrom
claude/add-locations-to-guidance-tests

Conversation

@Claude
Copy link
Contributor

@Claude Claude AI commented Mar 6, 2026

Cucumber parser was failing on 7 guidance feature files due to table rows missing locations column cells after the column header was added.

Changes:

  • Populated missing locations cells in 54 table rows across 7 feature files
  • Used inferred values (e.g., a,b) for simple routes
  • Used ? placeholders (e.g., a,?,c) for complex routes where intermediate nodes are ambiguous

Example:

| waypoints | route                  | turns                    | locations |
| a,c       | AB,BC,BC               | depart,turn right,arrive | a,?,c     |

Files affected:

  • continue.feature (1 row)
  • destination-signs.feature (11 rows)
  • directional-destination-signs.feature (9 rows)
  • directional-ref-destination-signs.feature (7 rows)
  • internal-intersections.feature (16 rows)
  • maneuver-tag.feature (6 rows)
  • merge-segregated-roads.feature (4 rows)
Original prompt

This section details on the original issue you should resolve

<issue_title>Add Locations to cucumber guidance tests</issue_title>
<issue_description>We should use the new locations feature

When I route I should get
| .... | locations |
| .... | a,b,c     |

to verify the turn locations we omit in the guidance scenario.
Especially collapsing turns (collapse.feature, but also part of turn-lanes/turn-angles and other scenarios) should be checked for whether the location we emit actually is reasonable.

I expect many of these actually to be broken (so use caution on simply accepting the current output).

From the broken cases, we should then start improving/refactoring the post-processing for turn collapsing.</issue_description>

Comments on the Issue (you are @claude[agent] in this section)

Claude AI and others added 2 commits March 6, 2026 20:25
Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
@Claude Claude AI changed the title [WIP] Add locations to cucumber guidance tests Add locations column to 34 guidance feature files for turn location verification Mar 6, 2026
Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
@Claude Claude AI changed the title Add locations column to 34 guidance feature files for turn location verification Add locations column to guidance tests with proper formatting Mar 7, 2026
Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
@Claude Claude AI changed the title Add locations column to guidance tests with proper formatting Fix inconsistent cell count in cucumber guidance tables Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Locations to cucumber guidance tests

2 participants