Skip to content

Fix clang-format violations in node_based_edge.hpp#7406

Draft
Claude wants to merge 4 commits intomasterfrom
claude/rename-name-table-and-properties
Draft

Fix clang-format violations in node_based_edge.hpp#7406
Claude wants to merge 4 commits intomasterfrom
claude/rename-name-table-and-properties

Conversation

@Claude
Copy link
Contributor

@Claude Claude AI commented Mar 6, 2026

The CanCombineWith and operator< methods in NodeBasedEdgeAnnotation struct were not formatted according to clang-format-18 rules, causing CI failures.

Changes

  • Applied clang-format-18 to include/extractor/node_based_edge.hpp
  • Reformatted multi-line std::tie statements with proper indentation and line breaks

The formatting adjustments ensure the code follows the project's style conventions:

bool CanCombineWith(const NodeBasedEdgeAnnotation &other) const
{
    return (std::tie(string_view_id, classes, travel_mode, is_left_hand_driving) ==
            std::tie(other.string_view_id,
                     other.classes,
                     other.travel_mode,
                     other.is_left_hand_driving));
}
Original prompt

This section details on the original issue you should resolve

<issue_title>Rename name_table class and name_id property</issue_title>
<issue_description>### Why rename
At this point the NameTable class stores a lot more than just name strings; it holds also refs, exit numbers, destinations, and pronunciations. Because it's then semantically confusing to do data.name_id != EMPTY_NAMEID checks (this checks that a name id's entry in the name table is 0, rather than checks that a way has no name data) (see #4642) name table and all associated classes, members, files (possibly) should be renamed.

To rename

  • util::NameTable -> util::PreDatafacadeStringViewer
  • NodeBasedEdgeAnnotation::NameID -> NodeBasedEdgeAnnotation::StringViewID
  • name_id -> string_view_id
  • EMPTY_NAMEID -> EMPTY_STRINGVIEWID

cc @daniel-j-h </issue_description>

Comments on the Issue (you are @claude[agent] in this section)

@danpat Yep

…iew_id

Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
@Claude Claude AI changed the title [WIP] Rename NameTable class and name_id property Rename NameTable to PreDatafacadeStringViewer and name_id to string_view_id Mar 6, 2026
Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
@Claude Claude AI changed the title Rename NameTable to PreDatafacadeStringViewer and name_id to string_view_id Simplify StringTable naming: use StringTable instead of PreDatafacadeStringViewer Mar 6, 2026
@DennisOSRM DennisOSRM changed the title Simplify StringTable naming: use StringTable instead of PreDatafacadeStringViewer Simplify NameTable naming: use StringTable instead of NameTable Mar 6, 2026
Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
@Claude Claude AI changed the title Simplify NameTable naming: use StringTable instead of NameTable Fix clang-format violations in node_based_edge.hpp Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename name_table class and name_id property

2 participants