Add include-what-you-use (IWYU) support for header dependency checking#7405
Draft
Add include-what-you-use (IWYU) support for header dependency checking#7405
Conversation
Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tooling to detect and prevent unnecessary header inclusions that cause excessive recompilation. For example, modifying
include/guidance/intersection_handler.hppcurrently triggers recompilation of unrelated files likesrc/updater/updater.cppandsrc/contractor/contractor.cpp.Changes
CI Workflow (
.github/workflows/iwyu.yml): New job using LLVM 18 and IWYU from apt.llvm.org, runs on PRs and master. Reports header issues as warnings without blocking builds.CMake Integration: Added
ENABLE_IWYUoption (OFF by default) to run IWYU during compilation. Follows same pattern asENABLE_CLANG_TIDY.Mapping File (
iwyu.imp): Configured standard library and third-party dependency mappings to reduce false positives.Usage
cmake .. -DENABLE_IWYU=ON -DCMAKE_CXX_COMPILER=clang++-18 make -j$(nproc)IWYU suggestions appear during compilation. Use
iwyu_tool.pyandfix_includes.pyfor automated fixes.Original prompt