Skip to content

Es6 nodejs tests#7401

Open
MarcelloPerathoner wants to merge 2 commits intoProject-OSRM:masterfrom
MarcelloPerathoner:es6-nodejs-tests
Open

Es6 nodejs tests#7401
MarcelloPerathoner wants to merge 2 commits intoProject-OSRM:masterfrom
MarcelloPerathoner:es6-nodejs-tests

Conversation

@MarcelloPerathoner
Copy link
Contributor

Update NodeJS tests

  • Incorporate eslint suggestions: arrow operator, single quotes, indent=2, etc.
  • Load OSRM once only
  • Add an environment variable to load OSRM from a configurable directory.

The last point enables testing from a cmake --install directory, so as to catch missing dynamic libraries, wrong RPATH etc.

@DennisOSRM
Copy link
Collaborator

Is there a chance we could separate this into two prs, one for reformatting and another for the functional change?

@MarcelloPerathoner
Copy link
Contributor Author

The functional change is contained entirely in the file constants.js and in the first few lines of each other file, those that say import. The rest is formatting only.

@DennisOSRM
Copy link
Collaborator

Could we do this in two PRs? The first changes formatting and the second the functional change.

I know this is a bit cumbersome, but provides more clarity during debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants