Allow -1.0 as unlimited for default_radius value#6599
Allow -1.0 as unlimited for default_radius value#6599SiarheiFedartsou merged 5 commits intoProject-OSRM:masterfrom
Conversation
|
It might be nice to align the UI here with what we support on the API - decimal values >= 0, and the string |
@danpat Okay, I've made a change that should allow "unlimited" to be passed and evaluated accordingly for both the |
SiarheiFedartsou
left a comment
There was a problem hiding this comment.
LGTM
@whytro can you please resolve conflict in CHANGELOG?
Issue
Relevant to:
This is an adjustment to PR #6575 to allow -1.0 to be used as an "unlimited" radius for the default radius flag. In effect, this would allow the user to define an unlimited radius default. This is useful for when the default starting behavior might be changed (ie. with #6572), and allow for the following interaction:
-1.0: unlimited radius range defaultunset: no default radius range, return error when bearings are not accompanied by radiuses15: default radius range of 15Currently this PR sets the default value in the engine_config to be -1.0 in order to avoid being a breaking change, so the default behavior is still unlimited if not set.
Tasklist
Requirements / Relations
Related to: