Skip to content

Adding pybind11 explicitly#8814

Merged
ericspod merged 3 commits intoProject-MONAI:devfrom
ericspod:pybind11_fix
Apr 9, 2026
Merged

Adding pybind11 explicitly#8814
ericspod merged 3 commits intoProject-MONAI:devfrom
ericspod:pybind11_fix

Conversation

@ericspod
Copy link
Copy Markdown
Member

@ericspod ericspod commented Apr 9, 2026

Fixes #8813.

Description

This fixes the missing pybind11 requirement for pytype.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
@ericspod ericspod requested a review from KumoLiu as a code owner April 9, 2026 19:52
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 891bf7e4-e632-4e3c-80e7-1a0146c9a560

📥 Commits

Reviewing files that changed from the base of the PR and between 8d39519 and a8d844f.

📒 Files selected for processing (2)
  • .github/workflows/pythonapp.yml
  • requirements-dev.txt

📝 Walkthrough

Walkthrough

Two files updated to explicitly include pybind11 as a dependency for pytype. The GitHub Actions workflow's quick-py3 job pip install command and requirements-dev.txt both add pybind11. No other packages, logic, or configuration changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Title accurately summarizes the main change: explicitly adding pybind11 as a dependency.
Description check ✅ Passed Description follows template structure with issue reference, clear problem statement, and types of changes marked appropriately.
Linked Issues check ✅ Passed Changes directly address issue #8813: pybind11 is added to both workflow CI config and development requirements.
Out of Scope Changes check ✅ Passed All changes are in-scope: modifications limited to adding pybind11 in two files aligned with the stated objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ericspod added 2 commits April 9, 2026 20:54
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@garciadias garciadias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Eric.

@ericspod ericspod enabled auto-merge (squash) April 9, 2026 21:54
@ericspod ericspod merged commit deb3f98 into Project-MONAI:dev Apr 9, 2026
33 of 34 checks passed
@ericspod ericspod deleted the pybind11_fix branch April 9, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pybind11 Missing When Installing Pytype

2 participants