Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion monai/data/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -881,7 +881,7 @@ def compute_shape_offset(
Default is False, using option 1 to compute the shape and offset.

"""
shape = np.array(spatial_shape, copy=True, dtype=float)
shape = np.array(tuple(spatial_shape), copy=True, dtype=float)
sr = len(shape)
in_affine_ = convert_data_type(to_affine_nd(sr, in_affine), np.ndarray)[0]
out_affine_ = convert_data_type(to_affine_nd(sr, out_affine), np.ndarray)[0]
Expand Down
60 changes: 60 additions & 0 deletions tests/data/utils/test_compute_shape_offset.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
# Copyright (c) MONAI Consortium
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
# http://www.apache.org/licenses/LICENSE-2.0
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from __future__ import annotations

import unittest

import numpy as np
import torch

from monai.data.utils import compute_shape_offset


class TestComputeShapeOffset(unittest.TestCase):
"""Unit tests for :func:`monai.data.utils.compute_shape_offset`."""

def setUp(self):
"""Set up a 4x4 identity affine used across all test cases."""
self.affine = np.eye(4)

def test_numpy_array_input(self):
"""Verify compute_shape_offset accepts a numpy array as spatial_shape."""
shape = np.array([64, 64, 64])
out_shape, _ = compute_shape_offset(shape, self.affine, self.affine)
self.assertEqual(len(out_shape), 3)

def test_list_input(self):
"""Verify compute_shape_offset accepts a plain list as spatial_shape."""
shape = [64, 64, 64]
out_shape, _ = compute_shape_offset(shape, self.affine, self.affine)
self.assertEqual(len(out_shape), 3)

def test_torch_tensor_input(self):
"""Verify compute_shape_offset accepts a torch.Tensor as spatial_shape.

This path broke in PyTorch >= 2.9 because np.array() relied on the
non-tuple sequence indexing protocol that PyTorch removed. Wrapping with
tuple() fixes it.
"""
shape = torch.tensor([64, 64, 64])
out_shape, _ = compute_shape_offset(shape, self.affine, self.affine)
self.assertEqual(len(out_shape), 3)

def test_identity_affines_preserve_shape(self):
"""Verify that identity in/out affines produce an output shape matching the input."""
shape = torch.tensor([32, 48, 16])
out_shape, _ = compute_shape_offset(shape, self.affine, self.affine)
np.testing.assert_allclose(np.array(out_shape, dtype=float), shape.numpy().astype(float), atol=1e-5)


if __name__ == "__main__":
unittest.main()
Loading