Skip to content

Fix make_gaussian_kernel truncated parameter for kernel_size > 3 #8811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atharvajoshi01 wants to merge 1 commit into
base: dev
Choose a base branch
from
+3 −1
Open

Fix make_gaussian_kernel truncated parameter for kernel_size > 3 #8811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion monai/losses/image_dissimilarity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ def make_triangular_kernel(kernel_size: int) -> torch.Tensor:

def make_gaussian_kernel(kernel_size: int) -> torch.Tensor:
sigma = torch.tensor(kernel_size / 3.0)
kernel = gaussian_1d(sigma=sigma, truncated=kernel_size // 2, approx="sampled", normalize=False) * (
# truncated is the number of std devs; set so that tail = kernel_size // 2
truncated = (kernel_size // 2) / float(sigma)
kernel = gaussian_1d(sigma=sigma, truncated=truncated, approx="sampled", normalize=False) * (
2.5066282 * sigma
)
return kernel[:kernel_size]
Expand Down
Loading