8620 modulenotfounderror no module named onnxscript in test py3x 311 pipeline#8638
Merged
garciadias merged 17 commits intoProject-MONAI:devfrom Nov 25, 2025
Conversation
Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com>
Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com>
Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com>
…script-in-test-py3x-311-pipeline
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: ba56a6d Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com>
Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com>
Contributor
WalkthroughThe pull request modifies Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Areas requiring extra attention:
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 9f4d989 Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com>
…script-in-test-py3x-311-pipeline Signed-off-by: Rafael Garcia-Dias <rafaelagd@gmail.com>
for more information, see https://pre-commit.ci
…rror-no-module-named-onnxscript-in-test-py3x-311-pipeline
ericspod
approved these changes
Nov 21, 2025
…rror-no-module-named-onnxscript-in-test-py3x-311-pipeline
Contributor
|
/build |
Borda
pushed a commit
to Borda/MONAI
that referenced
this pull request
Jan 6, 2026
…pipeline (Project-MONAI#8638) Fixes Project-MONAI#8620 . ### Description Adds `onnxscript` as an explicit dependency. I have tried to find where this onnxscript package was coming from before. For that, I tried all Python versions from 3.9 to 3.12, all versions of onnxruntime and onnx_graphsurgeon, and all versions later than 1.13.0 of onnx. None of these would include `onnxscript`. I suppose that this was a requirement of another library and was removed in some new version. I don't think it is worth the trouble of further investigating to find which package it was, since we wouldn't want to freeze a package version for this reason. So, instead, I propose we just add onnxscript as a dependency. ### Potential issue I am not sure if this will trigger the running of the ONNX tests in Python < 3.10 and how it will impact those tests. A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com> Signed-off-by: Rafael Garcia-Dias <rafaelagd@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: jirka <jirka.borovec@seznam.cz>
Rusheel86
pushed a commit
to Rusheel86/MONAI
that referenced
this pull request
Feb 25, 2026
…pipeline (Project-MONAI#8638) Fixes Project-MONAI#8620 . ### Description Adds `onnxscript` as an explicit dependency. I have tried to find where this onnxscript package was coming from before. For that, I tried all Python versions from 3.9 to 3.12, all versions of onnxruntime and onnx_graphsurgeon, and all versions later than 1.13.0 of onnx. None of these would include `onnxscript`. I suppose that this was a requirement of another library and was removed in some new version. I don't think it is worth the trouble of further investigating to find which package it was, since we wouldn't want to freeze a package version for this reason. So, instead, I propose we just add onnxscript as a dependency. ### Potential issue I am not sure if this will trigger the running of the ONNX tests in Python < 3.10 and how it will impact those tests. A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com> Signed-off-by: Rafael Garcia-Dias <rafaelagd@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8620 .
Description
Adds
onnxscriptas an explicit dependency.I have tried to find where this onnxscript package was coming from before. For that, I tried all Python versions from 3.9 to 3.12, all versions of onnxruntime and onnx_graphsurgeon, and all versions later than 1.13.0 of onnx.
None of these would include
onnxscript.I suppose that this was a requirement of another library and was removed in some new version.
I don't think it is worth the trouble of further investigating to find which package it was, since we wouldn't want to freeze a package version for this reason. So, instead, I propose we just add onnxscript as a dependency.
Potential issue
I am not sure if this will trigger the running of the ONNX tests in Python < 3.10 and how it will impact those tests.
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.