Skip to content

8185 tests refactor - Simplify nested for loops #8404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
garciadias wants to merge 110 commits into from

Refactor test_box_transform to use dict_product for parameter combina…

e3dfbc4
Select commit
Loading
Failed to load commit list.
Closed

8185 tests refactor - Simplify nested for loops #8404

Refactor test_box_transform to use dict_product for parameter combina…
e3dfbc4
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Mar 28, 2025 in 1s

DCO

There are 65 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.

Preferred method: Commit author adds a DCO remediation commit

A DCO Remediation Commit contains special text in the commit message that applies a missing Signed-off-by line in a subsequent commit. The primary benefit of this method is that the project’s history does not change, and there is no risk of breaking someone else’s work.

These authors can unblock this PR by adding a new commit to this branch with the following text in their commit message:

R. Garcia-Dias <rafaelagd@gmail.com>

DCO Remediation Commit for R. Garcia-Dias <rafaelagd@gmail.com>

I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: d37a56885ee1b8fe1bd8a0d5ea7c2a65e1f5a89f
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: fe0ce22644d7dc34805437cc2c265043a558ff72
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 204cb513434407d90b45cdf0a4e28d7dd0cacfc3
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 5067d68b6c60e99397f65a3797fadeced29da227
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 63954be548090397e21c3311f01aabf6bf0bba05
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: a18be5f509d9b0e990610b224e2d46d709f68c49
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: a627a610b98bbbc3d77007b42ad6a706361b5ff0
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: be546500f3c12265a6843ad1c5d7ba2f193796d6
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: d4a818fb9f070a4d53aa9ebadf618c486f71b3a8
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 8d4a657372500cd2a4465fc15dfe908c57b07da3
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 30a1e63a675712999667c0576f06ab64c92a17e8
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 8ecdd160ffbff72c9ca7637869c2fb47a554742e
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 1e281a65496550673abb9bb88cc33885b5484b3e
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: fbbcafce30f91b38c0c3a5f8228dc03d5c8f339d
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: e7e48ae37b3013efacb957ef5c2d9a9c69dafd0a
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 63b73d940ae7df9484f951595f47326e786db0a2
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 70966c062ac346bb76001e5f270dc5acdad66cb1
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 48b4ef2158b8ce181bd31224671a3b1cff4f5500
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 4b07a2da7d04dcdeaee07470fa14393736ab5bd4
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: c80df4528fe52c89c4ea64db722aa58e679e5f8c
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 9f3474e398ebd2aa395247c437db7ace183eae43
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 2481afb6e6e85c9c7192aa47e5625e27ec27c66f
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 21132b5961b710d84e1359de1b6d27a810a2853a
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 35e3036cf023354c8e199896ae9f69c6259b8135
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 724755571a19ec8245a2b521736d61f7c9c2caaf
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 9bb9cec5293ee51eb0eb116eebe67ef752362db3
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 1a6b9b37e200bcc3efea72a2d3d1524bd863fe1b
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: cdda08aa8df2fc9b494b72932564bbe436f0c31e
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 86fa124b6dd9641f5a27ca1c0917e7b755857fb3
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 638fb06cc1ed18f2ea243f87f1086c3753199935
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 5033d9f8a6d9f87f6e8a79051aa41a72ae0bbf3c
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: c0b0cf42c9f612b11db8dd3decff2e9fe6823979
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: f42bdd2fea03f1888c3f5f417a560f196d4b9938
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 8a0baa747000df59f3379ec58140c4f3df536efd
I, R. Garcia-Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: afe3caae40d198c5ab6f2317ac15e7911c370e92

Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com>

Rafael Dias <rafaelagd@gmail.com>

DCO Remediation Commit for Rafael Dias <rafaelagd@gmail.com>

I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 075ec11ed348c75ee838ad5a73dc1ef6e607b834
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: e8d3e19fde39f63edfaa4696ae0047fd514669a5
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: d4b01e6ba5860fe79b98c0aced17cfe1d06d3dbc
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: bfc68a494ace8a367a61515d37e2d1c206032766
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 55fcd220fa3e465d78e59c6de1c0334ed246f344
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: ba167434e2d72b91cc024314e3943383fe9f7c79
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 1667eb78cae1475df439db7121e710246bb1bfb1
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 9a2c2f417159dad59cf680ccfb6f1d3acdfc68e2
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: f2cf158514dd034c3c1121163d2a029ce53640eb
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: b3fd8e9f2048fd9e133df00e73335ba5d104ac82
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 114fc72e7e944bcf02750b796cee78f4a10dadab
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 626e0509918a542e02bc390e7f8a7582545113c9
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 4c6b59cbca45cefc5c5462aa833bae9aac66a18b
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 2d5507470ef8e5688aad16dfc79b7240a16d3f4c
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: bf8222598d6ba2e45f17ef28ee183d32b3ca5932
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 56c2a483a6109e4c3317db4143aa2f1f3ecba7fa
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 98d3ab27422ebd00b275b6eacd4f7eef13c25cee
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: a0d23956a530bc1d5734033b5cf129aa9a0f8357
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 8831dc0eb49dd3477b931ed5a29e76c4d28e6f49
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: bb85f536a569566e1c2eed502b2d5ea445e14092
I, Rafael Dias <rafaelagd@gmail.com>, hereby add my Signed-off-by to this commit: 865dc22ffa1774faa56c889fa82c0949ba109b22

Signed-off-by: Rafael Dias <rafaelagd@gmail.com>

Rafael Garcia-Dias <rd24@lihe055-pc.isd.kcl.ac.uk>

DCO Remediation Commit for Rafael Garcia-Dias <rd24@lihe055-pc.isd.kcl.ac.uk>

I, Rafael Garcia-Dias <rd24@lihe055-pc.isd.kcl.ac.uk>, hereby add my Signed-off-by to this commit: cf1025a6b98f709c4fb2a7da09de39995080935c

Signed-off-by: Rafael Garcia-Dias <rd24@lihe055-pc.isd.kcl.ac.uk>

rd24_lihe055 <rafael.dias@kcl.ac.uk>

DCO Remediation Commit for rd24_lihe055 <rafael.dias@kcl.ac.uk>

I, rd24_lihe055 <rafael.dias@kcl.ac.uk>, hereby add my Signed-off-by to this commit: 069b07c1032eb61ec3c3c327d1df0b865df9c71d
I, rd24_lihe055 <rafael.dias@kcl.ac.uk>, hereby add my Signed-off-by to this commit: a4a0baa72eedffec5d739acee0a0ea3d43f83904
I, rd24_lihe055 <rafael.dias@kcl.ac.uk>, hereby add my Signed-off-by to this commit: 34627e8ec8aed6dff205649db40cae17084b4581
I, rd24_lihe055 <rafael.dias@kcl.ac.uk>, hereby add my Signed-off-by to this commit: 08cd2ac295075d8e7fb3a5a89ec335dcbcab5b7c
I, rd24_lihe055 <rafael.dias@kcl.ac.uk>, hereby add my Signed-off-by to this commit: 74d04816af049c59d43d831e6b3f62ec8457c9bf
I, rd24_lihe055 <rafael.dias@kcl.ac.uk>, hereby add my Signed-off-by to this commit: 10912661e025c6d48369b07e13049001f3e330cc
I, rd24_lihe055 <rafael.dias@kcl.ac.uk>, hereby add my Signed-off-by to this commit: 58e9e3bf2a14ceea5ae0be96ef1dc5df5446e98d
I, rd24_lihe055 <rafael.dias@kcl.ac.uk>, hereby add my Signed-off-by to this commit: f8d9bcf93b0611e6d134858da9c22b080dd67fda

Signed-off-by: rd24_lihe055 <rafael.dias@kcl.ac.uk>

Please note: You should avoid adding empty commits (i.e., git commit -s --allow-empty), because these will be discarded if someone rebases the branch / repo.

Least preferred method: Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~110 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin 8185-tests-refactor

Summary

Commit sha: d37a568, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: fe0ce22, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 204cb51, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 5067d68, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 63954be, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: a18be5f, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: a627a61, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: be54650, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: d4a818f, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 8d4a657, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 30a1e63, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 8ecdd16, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 1e281a6, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: fbbcafc, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: e7e48ae, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 63b73d9, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 70966c0, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 48b4ef2, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 4b07a2d, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: c80df45, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 9f3474e, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 2481afb, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 21132b5, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 35e3036, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 7247555, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 9bb9cec, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 1a6b9b3, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: cdda08a, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 86fa124, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 638fb06, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 5033d9f, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: c0b0cf4, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: f42bdd2, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 8a0baa7, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: afe3caa, Author: R. Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 075ec11, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: e8d3e19, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: d4b01e6, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: bfc68a4, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: 55fcd22, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: ba16743, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: 1667eb7, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: 9a2c2f4, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: f2cf158, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: b3fd8e9, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: 114fc72, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: 626e050, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: 4c6b59c, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: 2d55074, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: bf82225, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: 56c2a48, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: 98d3ab2, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: a0d2395, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: 8831dc0, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: bb85f53, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: 865dc22, Author: Rafael Dias, Committer: Rafael Dias; The sign-off is missing.
Commit sha: cf1025a, Author: Rafael Garcia-Dias, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 069b07c, Author: rd24_lihe055, Committer: rd24_lihe055; The sign-off is missing.
Commit sha: a4a0baa, Author: rd24_lihe055, Committer: rd24_lihe055; The sign-off is missing.
Commit sha: 34627e8, Author: rd24_lihe055, Committer: rd24_lihe055; The sign-off is missing.
Commit sha: 08cd2ac, Author: rd24_lihe055, Committer: rd24_lihe055; The sign-off is missing.
Commit sha: 74d0481, Author: rd24_lihe055, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 1091266, Author: rd24_lihe055, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: 58e9e3b, Author: rd24_lihe055, Committer: R. Garcia-Dias; The sign-off is missing.
Commit sha: f8d9bcf, Author: rd24_lihe055, Committer: R. Garcia-Dias; The sign-off is missing.

View more details on DCO