Open
Conversation
…hal panic
Adds tests verifying UnmarshalMap does not panic when decoding into
struct fields of interface type that already hold concrete values.
Covers three scenarios:
- nil interface (decodes to map[string]interface{})
- pointer to struct (decodes into existing struct)
- struct value (should not panic with reflect.Set error)
Also adds test for named interface fields (e.g., fmt.Stringer) to
ensure graceful handling when map[string]interface{} is not assignable.
…ields
Fixes decodeMap to avoid panic when an interface field already holds
a concrete type that is not assignable from map[string]interface{}.
When the interface contains a pointer to struct, decode into it directly.
When it contains a non-pointer struct or incompatible type, handle
gracefully instead of calling reflect.Set with an incompatible value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a panic bug we hit.