Skip to content

Fix comment type check missing empty string in email formatting #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdevalk wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix comment type check missing empty string in email formatting #177

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d40c3c
fix: handle empty comment_type in email formatting
jdevalk Feb 5, 2026
6c8b532
Merge develop into fix/comment-type-comparison
jdevalk Feb 5, 2026
fc6cdc4
Merge branch 'develop' into fix/comment-type-comparison
jdevalk Feb 5, 2026
c42b048
Merge branch 'develop' into fix/comment-type-comparison
jdevalk Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions inc/clean-emails.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ private function add_comment_basics(): void {
* @return void
*/
private function add_author_line(): void {
if ( $this->comment->comment_type === 'comment' ) {
if ( $this->comment->comment_type !== 'pingback' && $this->comment->comment_type !== 'trackback' ) {
/* translators: %1$s is replaced with the comment author's name, %2$s is replaced with the comment author's email */
$this->message .= \sprintf( \esc_html__( 'Author: %1$s (%2$s)', 'yoast-comment-hacks' ), \esc_html( $this->comment->comment_author ), '<a href="' . \esc_url( 'mailto:' . $this->comment->comment_author_email ) . '">' . \esc_html( $this->comment->comment_author_email ) . '</a>' ) . '<br />';
}
Expand All @@ -197,7 +197,7 @@ private function add_author_line(): void {
* @return void
*/
private function add_content_line(): void {
if ( $this->comment->comment_type === 'comment' ) {
if ( $this->comment->comment_type !== 'pingback' && $this->comment->comment_type !== 'trackback' ) {
$this->message .= \esc_html__( 'Comment:', 'yoast-comment-hacks' );
}
else {
Expand Down
Loading