UPDATE sedalib: Saphir team adaptations to Sedalib to address missing elements #95
Conversation
|
New Issues (1)Checkmarx found the following issues in this Pull Request
Use @Checkmarx to reach out to us for assistance. Just send a PR comment with Examples: |
GiooDev
changed the title
marob
left a comment
marob
left a comment
There was a problem hiding this comment.
Pourquoi contribuer des classes Saphir qui ne sont a priori pas utilisées par sedatools ? Si ces classes sont utilisées dans un projet utilisant sedatools, il serait préférables qu'elles soient créées dans ce projet et non dans sedatools.
| */ | ||
| public Integer getTouchedInDataObjectPackageId(String inDataObjectPackageId) { | ||
| return touchedInDataObjectPackageIdMap.get(inDataObjectPackageId); | ||
| return touchedInDataObjectPackageIdMap.getOrDefault(inDataObjectPackageId,0); |
There was a problem hiding this comment.
Formatage inconsistant (manque un espace après la virgule)
There was a problem hiding this comment.
Revert les changements de formatage
| * Creates a root archive unit in the SIP. | ||
| * Nouvelle signature de la méthode pour descriptionLevel et title uniquement | ||
| * et éviter la géneration de la balise <Description></Description> vide. |
| ArchiveUnit au = createRootArchiveUnit(archiveUnitID); | ||
|
|
||
| Content c = new Content(); | ||
| try { | ||
| c.addNewMetadata("DescriptionLevel", descriptionLevel); | ||
| c.addNewMetadata("Title", title); | ||
| c.addNewMetadata("Description", description); | ||
| } catch (SEDALibException ignored) { | ||
| // ignored | ||
| } | ||
| au.setContent(c); |
There was a problem hiding this comment.
Pour éviter la duplication de code :
| ArchiveUnit au = createRootArchiveUnit(archiveUnitID, descriptionLevel, title); | |
| try { | |
| au.getContent().addNewMetadata("Description", description); | |
| } catch (SEDALibException ignored) { | |
| // ignored | |
| } |
|
fix with #96 |
4 participants
No description provided.