-
Notifications
You must be signed in to change notification settings - Fork 0
Rename stale industrial dashboard and workflow wording #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| name: CompText V7 Industrial Validation | ||
| name: CompText V7 Replay Validation | ||
|
|
||
| on: | ||
| pull_request: | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,5 +3,5 @@ import { percent, relativeTime } from '../../lib/format'; | |
| import type { DashboardPayload } from '../../types/domain'; | ||
|
|
||
| export function ReplayPage({ payload }: { payload: DashboardPayload }) { | ||
| return <div className="grid"><section className="grid cols-4"><article className="card"><h3>Determinism</h3><div className="metric">{payload.replay.stable ? 'Stable' : 'Drift'}</div><span className={`badge ${payload.replay.stable ? 'nominal' : 'critical'}`}>{payload.replay.mismatches} mismatches</span></article><article className="card"><h3>Replay passes</h3><div className="metric">{payload.replay.passes}</div><p>Last run {relativeTime(payload.replay.last_run_at)}</p></article><article className="card"><h3>Corpus size</h3><div className="metric">{payload.replay.corpus_size}</div><p>Golden industrial fixtures</p></article><article className="card"><h3>Tokenizer</h3><div className="metric">{payload.audit_summary.tokenizer_version}</div><p className="mono">{payload.audit_summary.tokenizer_drift_fingerprint.slice(0, 24)}</p></article></section><article className="card"><div className="card-header"><div><h3>Drift severity timeline</h3><p>Dataset-level findings from typed replay and forensic APIs.</p></div></div><BarChart data={payload.drift_severity_timeline.map((point) => ({ label: point.dataset, value: point.critical * 4 + point.high * 2 + point.medium, auxiliary: point.low }))} valueLabel={(value) => percent(value, 0)} /></article></div>; | ||
| return <div className="grid"><section className="grid cols-4"><article className="card"><h3>Determinism</h3><div className="metric">{payload.replay.stable ? 'Stable' : 'Drift'}</div><span className={`badge ${payload.replay.stable ? 'nominal' : 'critical'}`}>{payload.replay.mismatches} mismatches</span></article><article className="card"><h3>Replay passes</h3><div className="metric">{payload.replay.passes}</div><p>Last run {relativeTime(payload.replay.last_run_at)}</p></article><article className="card"><h3>Corpus size</h3><div className="metric">{payload.replay.corpus_size}</div><p>Golden replay fixtures</p></article><article className="card"><h3>Tokenizer</h3><div className="metric">{payload.audit_summary.tokenizer_version}</div><p className="mono">{payload.audit_summary.tokenizer_drift_fingerprint.slice(0, 24)}</p></article></section><article className="card"><div className="card-header"><div><h3>Drift severity timeline</h3><p>Dataset-level findings from typed replay and forensic APIs.</p></div></div><BarChart data={payload.drift_severity_timeline.map((point) => ({ label: point.dataset, value: point.critical * 4 + point.high * 2 + point.medium, auxiliary: point.low }))} valueLabel={(value) => percent(value, 0)} /></article></div>; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The line length here is extremely long (over 1000 characters), which is a significant maintainability issue. It is much better to format this JSX across multiple lines to make the structure clear and easier to modify in the future. |
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is excessively long (over 600 characters), which makes it difficult to read and maintain. Breaking the JSX structure into multiple lines would significantly improve the readability of this component.