Remove obsolete Gemini and embedded showcase remnants#213
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the showcase application and its associated source files, configurations, and assets from the repository, redirecting showcase development to a separate project. Updates were made to documentation, repository layout validation scripts, and tests to reflect this change. A review comment suggests further simplifying the repository layout tests by removing redundant file existence assertions that are already covered by the main validation function.
| assert (REPO_ROOT / "package.json").is_file() | ||
| assert (REPO_ROOT / "dashboard" / "app" / "package.json").is_file() | ||
| assert (REPO_ROOT / "showcase" / "app" / "package.json").is_file() | ||
| assert check_repo_layout() == [] |
There was a problem hiding this comment.
These explicit file existence assertions are redundant because check_repo_layout() already validates these exact paths (and others) as part of its REQUIRED_FILES check. Removing them simplifies the test while maintaining the same level of validation.
| assert (REPO_ROOT / "package.json").is_file() | |
| assert (REPO_ROOT / "dashboard" / "app" / "package.json").is_file() | |
| assert (REPO_ROOT / "showcase" / "app" / "package.json").is_file() | |
| assert check_repo_layout() == [] | |
| assert check_repo_layout() == [] |
Summary
GEMINI.mdshowcase/tree from the main repositoryshowcase/app/package.jsonis no longer requireddocs/reports/check-report.mdValidation
npm run layoutpytest tests/test_check_repo_layout.py -qpytest -qnpm run checkResult:
pytest -q: 384 passednpm run check: passedScope
Maintenance-only cleanup.
Not changed:
Next
README/industrial-positioning cleanup should be handled in a separate follow-up PR.