-
Notifications
You must be signed in to change notification settings - Fork 10
Add the Pixel 10 Series and Retroid Pocket 6 #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
Corrected a typo in the devices seeder for Pocket 6.
|
@jSQrD-dev is attempting to deploy a commit to the Producdevity's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe pull request adds five new device entries (Retroid Pocket 6, Google Pixel 10 Pro XL, Pixel 10 Pro, Pixel 10, and Pixel 9a) and introduces a new Tensor G5 SoC to the seed data, while adjusting the Tensor G4's CPU core count from 9 to 8. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@prisma/seeders/socSeeder.ts`:
- Around line 1166-1173: The GPU model value for the SoC entry with name 'Tensor
G5' in socSeeder.ts is unverified; either confirm the gpuModel 'PowerVR
DXT-48-1536' from a reliable source and update the gpuModel field accordingly in
the object literal, or remove the gpuModel property from that object (the block
containing name: 'Tensor G5', manufacturer: 'Google', architecture: 'ARM64',
processNode: '3nm', cpuCores: 8, gpuModel: 'PowerVR DXT-48-1536') so the seeder
only contains confirmed data.
https://en.wikipedia.org/wiki/Google_Tensor Don't know if these count as reliable but here are my sources |
Description
Fixes # (issue)
Type of change
How Has This Been Tested?
Tested if Prisma Properly seeded
Screenshots (if applicable)
Checklist
Notes for reviewers
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.