Feature/create board by workspace #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhymiz
reviewed
Jun 28, 2022
chdastolfo
previously approved these changes
Jun 29, 2022
Collaborator
Contributor
Author
|
Updated with type hints and some custom ones |
Contributor
Author
|
I think this should be ready to review now 😄 |
Collaborator
|
Thanks again @albcl, will take a look! |
rhymiz
approved these changes
Oct 29, 2022
Collaborator
|
@all-contributors please add @albcl for code |
Contributor
|
I've put up a pull request to add @albcl! 🎉 |
Collaborator
|
@all-contributors please add @albcl to code |
Contributor
Collaborator
|
@all-contributors please remove @albcl from code |
Contributor
|
I could not determine your intention. Basic usage: @all-contributors please add @Someone for code, doc and infra For other usages see the documentation |
albcl
added a commit
to albcl/monday
that referenced
this pull request
Dec 9, 2022
* Added "create board by workspace id" * Update readme * Added missing type hints * Updated test * More custom type hints * Type hints for 'get_boards_query' * Fixed tests * Updated Readme and 'fetch_boards' method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed:
Added
create_boards()function and a test for it.Also,
Readmehas been updated.What resolves:
Issue #59: Will allow users to easily create boards optionally specifying a workspace for it.